Change queryset in project viewset in order to return only projects associated to active organizations. #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankApiyo
changed the title
ivermac
reviewed
Jan 7, 2020
| created_by=alice_user, | ||
| organization=alice_user) | ||
| alice_profile.save() | ||
| alice_user.save() |
There was a problem hiding this comment.
Why are we calling .save() on alice_profile and alice_user objects?
ivermac
previously approved these changes
Jan 7, 2020
ivermac
previously approved these changes
Jan 7, 2020
ivermac
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Added a filter to the queryset in ProjectViewset to ensure that we do not return projects associated with inactive organizations
Steps taken to verify this change does what is intended
Ran onadata locally and ensured that only projects associated with active organizations are gotten from the projects endpoint
Fixes: #1732