Assign Owner permission to creator for organization account UserProfile #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisRayM
force-pushed
the
1754-ownerrole-org-permissions
branch
from
c2b11f6
to
60affe6
Compare
|
This PR contains one approach on how to solve the Issue. The approach: Assign Permissions for |
DavisRayM
force-pushed
the
1754-ownerrole-org-permissions
branch
3 times, most recently
from
98f4b69
to
47f0caf
Compare
DavisRayM
changed the title
DavisRayM
force-pushed
the
1754-ownerrole-org-permissions
branch
2 times, most recently
from
bed93a4
to
aa04155
Compare
ivermac
suggested changes
Jan 8, 2020
onadata/apps/api/tests/viewsets/test_organization_profile_viewset.py
Outdated
Show resolved
Hide resolved
DavisRayM
force-pushed
the
1754-ownerrole-org-permissions
branch
from
aa04155
to
ebf9753
Compare
- Add OwnerRole permissions to creator for OrganizationalProfile.userprofile_ptr
- Assign permission for OrganizationProfile.userprofile_ptr to the Owner of an Org
- Rename test_creator_and_user_permission to test_creator_permissions - Update test to verify object permissions are revoked
DavisRayM
force-pushed
the
1754-ownerrole-org-permissions
branch
from
ebf9753
to
20c29db
Compare
ukanga
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
OwnerRolepermissions to creator forOrganizationalProfile.userprofile_ptrRolepermissions from a user when they are removed from an organizationPending work on PR
Steps taken to verify this change does what is intended
Side effects of implementing this change
set_api_permissionsmanagement command needs to be runAdditional Information
Issue #1754 is being caused because the
Userobject returned throughUser.objects.getandget_object_or_404links to aUserProfileand not aOrganizationProfilewhenuser.profileis called. The user / creator in this case normally doesn't have the OwnerRole /can_add_xformattached to theUserProfile/org.userprofile_ptr.The
UserProfileis present due to how django handles model inheritances(more info on that here), as such it seems for some reason theUserobject defaults to linking toorg_profile.userprofile_ptrCloses #1754