-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use_master when fetching external export metadata information #1760
Conversation
da1cc4d
to
e9d7712
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good but can we test it by mocking? Check this link and search for ....side_effect can also be an iterable
which can guide us on how to mock this
Found the following as well but I forgot to post |
5b039e6
to
45561d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, have a few suggestions and comments.
Fix failing Tests
45561d9
to
71c8328
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Metadata details for extenal exports are being fetched from the replica database. This may fail if the record may still not be available in read replica.
Fixes #1758