Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change submission endpoint to be case-insensitive when matching usernames #1762

Merged
merged 2 commits into from
Jan 9, 2020
Merged

Change submission endpoint to be case-insensitive when matching usernames #1762

merged 2 commits into from
Jan 9, 2020

Conversation

DavisRayM
Copy link
Contributor

Changes / Features implemented

  • Query usernames case-insensitively
  • Properly validated usernames when creating users through OpenID Connect

Steps taken to verify this change does what is intended

  • Add test to make sure case doesn't matter when making submissions to /<username/submission

Side effects of implementing this change

Closes #1761

@DavisRayM DavisRayM changed the title Fix an issue where submission would not be made due to the usernames casing Change submission url to be case-insensitive when matching usernames Jan 9, 2020
@DavisRayM DavisRayM changed the title Change submission url to be case-insensitive when matching usernames Change submission endpoint to be case-insensitive when matching usernames Jan 9, 2020
ivermac
ivermac approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@ivermac ivermac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@DavisRayM DavisRayM merged commit 52ad042 into master Jan 9, 2020
@DavisRayM DavisRayM deleted the 1761-username-case-sensitivity-change branch January 9, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukanga ukanga ukanga approved these changes

@ivermac ivermac ivermac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usernames are currently case-sensitive while submitting to a form
3 participants
@DavisRayM @ukanga @ivermac