Handle error thrown by urllib

[DavisRayM]

Changes / Features implemented

• Handle BadStatusLine error raised when "a server responds with a HTTP status code that we don’t understand."

Steps taken to verify this change does what is intended

• Tested on a local server of onadata
• Added a test test_error_raised_xform_url_upload_urllib_error

Side effects of implementing this change

N/A

Closes #1759

[ivermac]

Looks good. Can we add a test for it by mocking the function that triggers BadStatusLine? We have an example of how to mock an exception by using a side_effect as seen below:

onadata/onadata/apps/api/tests/viewsets/test_charts_viewset.py

Lines 104 to 113 in fdd91d7

	@mock.patch('onadata.libs.data.query._execute_query',
	side_effect=raise_data_error)
	def test_get_on_date_field_with_invalid_data(self, mock_execute_query):
	data = {'field_name': 'date'}
	request = self.factory.get('/charts', data)
	force_authenticate(request, user=self.user)
	response = self.view(
	request,
	pk=self.xform.id)
	self.assertEqual(response.status_code, 400)

[DavisRayM]

Looks good. Can we add a test for it by mocking the function that triggers BadStatusLine? We have an example of how to mock an exception by using a side_effect as seen below:

onadata/onadata/apps/api/tests/viewsets/test_charts_viewset.py

Lines 104 to 113 in fdd91d7

	@mock.patch('onadata.libs.data.query._execute_query',
	side_effect=raise_data_error)
	def test_get_on_date_field_with_invalid_data(self, mock_execute_query):
	data = {'field_name': 'date'}
	request = self.factory.get('/charts', data)
	force_authenticate(request, user=self.user)
	response = self.view(
	request,
	pk=self.xform.id)
	self.assertEqual(response.status_code, 400)

Added.

[ivermac]

lgtm!

[ukanga]

What would the action that would be required by the user to take if they encounter this error?
Would the error message in https://github.com/onaio/onadata/pull/1765/files#diff-018f1a90f318bf1748393be886fee2c0R502-R503 be sufficient in this case? If it would be sufficient could we add BadStatusLine to except (BadStatusLine, MemoryError, OSError)?

[DavisRayM]

The error message would be perfect for this scenario. I'll update my PR.

[WNjihia]

Testing checks out @DavisRayM