Set deleted_by field when deleting XForms asynchronously #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivermac
reviewed
Mar 12, 2020
| xform.pk, | ||
| request.user.id).task_id, | ||
| u'time_async_triggered': datetime.now(), | ||
| u'triggered_by': request.user.username} |
There was a problem hiding this comment.
Do we need triggered_by since we'll be saving the user who triggered the delete?
There was a problem hiding this comment.
Mostly kept it they're for information purposes (if that makes sense) wanted to be extra verbose. On the first async task status just in case.
TL;DR: We don't really need it
There was a problem hiding this comment.
Cool, let's remove it for now and may be add it when we need it
There was a problem hiding this comment.
I've removed the triggered_by field in the latest commits. Please have a look @ivermac
DavisRayM
force-pushed
the
1797-track-user-xform-deletion
branch
from
a05822b
to
55a3bfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Steps taken to verify this change does what is intended
Side effects of implementing this change
Closes #1797