Handle dynamic choice names while generating SAV export #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisRayM
force-pushed
the
1803-dynamic-labels
branch
from
e2b132f
to
608874a
Compare
DavisRayM
commented
Apr 6, 2020
DavisRayM
force-pushed
the
1803-dynamic-labels
branch
4 times, most recently
from
bb62ddf
to
206ae6e
Compare
ukanga
reviewed
Apr 8, 2020
| self.assertEqual(rows[0][2], b'name') | ||
| self.assertEqual(rows[1][2], b'Davis') | ||
| self.assertEqual(rows[0][3], b'brand_known') | ||
| self.assertEqual(rows[1][3], b'${text} a') |
There was a problem hiding this comment.
@DavisRayM Are we supposed to replace ${text} with the real value i.e. '${text} a' becomes 'his a'?
There was a problem hiding this comment.
Yes, I think we do. I'll work on making this happen.
I think we need to do this since the csv export shows his a instead of ${text} a will work on this
DavisRayM
changed the title
DavisRayM
force-pushed
the
1803-dynamic-labels
branch
from
92f9eea
to
ebd0e45
Compare
DavisRayM
changed the title
Curly braces are categorized as special characters in SPSS. Including them in the 'var_name' raises a syntax error
Replace dynamic values i.e ${text} with actual value retrieved from row
data while creating sav exports
DavisRayM
force-pushed
the
1803-dynamic-labels
branch
from
ebd0e45
to
f449457
Compare
ukanga
approved these changes
Apr 9, 2020
|
@DavisRayM this has passed QA. I have tested the following scenarios
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Steps taken to verify this change does what is intended
Side effects of implementing this change
Closes #1803