Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RapidPro JSON webhook post requests #1807

Merged
merged 2 commits into from
Apr 9, 2020

Conversation

DavisRayM
Copy link
Contributor

@DavisRayM DavisRayM commented Apr 6, 2020

Changes / Features implemented

  • Added BaseRapidProSubmissionSerializer
  • Added RapidProJSONSubmissionSerializer

Steps taken to verify this change does what is intended

  • Added Tests
  • Personal QA

Side effects of implementing this change

  • n/a

Closes #1805

@DavisRayM DavisRayM force-pushed the 1805-rapidpro-webhook-refactor branch from 194020c to 0eb3ef4 Compare April 6, 2020 14:41
@DavisRayM DavisRayM force-pushed the 1805-rapidpro-webhook-refactor branch from 0eb3ef4 to 093a44c Compare April 6, 2020 14:57
ukanga
ukanga previously approved these changes Apr 6, 2020
@DavisRayM DavisRayM force-pushed the 1805-rapidpro-webhook-refactor branch 2 times, most recently from fdf1c44 to 011aa91 Compare April 7, 2020 05:32
Add RapidProJSONSubmissionSerializer; A serializer meant to handle JSON
webhook post requests from RapidPro
@DavisRayM DavisRayM force-pushed the 1805-rapidpro-webhook-refactor branch from 011aa91 to 97848d9 Compare April 8, 2020 06:42
@faith-mutua
Copy link

@DavisRayM I have managed to send submissions from a flow to a form only when running a flow on the rapidpro simulator. I couldn't get to send submissions when running the flow from a channel. I'll test this further tomorrow morning.

@faith-mutua faith-mutua added the QA- PR failed QA testing label Apr 8, 2020
@faith-mutua
Copy link

@DavisRayM This has passed QA. I have managed to pass submissions to a form linked to my flow by running my flow on both Telegram and Android channel.

@faith-mutua faith-mutua added QA+ PR passed QA testing and removed QA- PR failed QA testing labels Apr 9, 2020
@DavisRayM DavisRayM merged commit 3d8f197 into master Apr 9, 2020
@DavisRayM DavisRayM deleted the 1805-rapidpro-webhook-refactor branch April 9, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA+ PR passed QA testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RapidPro flow fails to make submissions to forms
3 participants