Refactor submission deletion queryset #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we add a test that it is now called? |
ivermac
suggested changes
Apr 7, 2020
There was a problem hiding this comment.
Looks good. As @moshthepitt has mentioned, we could just add a test to check the post_save signal is called. May be use mocking?
DavisRayM
previously approved these changes
Apr 8, 2020
moshthepitt
previously approved these changes
Apr 8, 2020
KipSigei
dismissed stale reviews from moshthepitt, DavisRayM, and ivermac
via
325d3bd
KipSigei
force-pushed
the
submission-deletion-tweaks
branch
from
ee3516e
to
325d3bd
Compare
moshthepitt
previously approved these changes
Apr 9, 2020
This is because .update() doesn't emit a post_save signal and doesn't call .save() on the Instance model Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
…tion Signed-off-by: Kipchirchir Sigei <[email protected]>
KipSigei
force-pushed
the
submission-deletion-tweaks
branch
from
325d3bd
to
9682942
Compare
DavisRayM
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
.update()since it doesn't call the Instance model's.save()method.update()method doesn't sendpost_savesignal required by google exports or any other micro serviceSteps taken to verify this change does what is intended
Side effects of implementing this change
Closes #