-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors encountered when utilizing a master-replica database setup #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisRayM
force-pushed
the
fix-500-caused-by-db-desync
branch
from
April 17, 2020 08:38
c6547c9
to
4a09316
Compare
ivermac
previously approved these changes
Apr 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
DavisRayM
changed the title
Fix 500 errors raised when utilizing a master-replica database setup
[WIP] Fix 500 errors raised when utilizing a master-replica database setup
Apr 17, 2020
DavisRayM
changed the title
[WIP] Fix 500 errors raised when utilizing a master-replica database setup
Fix 500 errors raised when utilizing a master-replica database setup
Apr 17, 2020
DavisRayM
force-pushed
the
fix-500-caused-by-db-desync
branch
from
April 17, 2020 11:34
35218f2
to
facc6a4
Compare
ivermac
previously approved these changes
Apr 20, 2020
DavisRayM
changed the title
Fix 500 errors raised when utilizing a master-replica database setup
Fix errors encountered when utilizing a master-replica database setup
Apr 20, 2020
DavisRayM
force-pushed
the
fix-500-caused-by-db-desync
branch
from
April 30, 2020 06:29
88c9efd
to
40d8c84
Compare
Retrieve organization owner team from the master database if unable to retrieve the team the first time
Modify Enketo submission and formList urls by changing the name of the "form_pk" arguement to "xform_pk"
DavisRayM
force-pushed
the
fix-500-caused-by-db-desync
branch
5 times, most recently
from
April 30, 2020 08:45
acdaec9
to
949a9a0
Compare
DavisRayM
force-pushed
the
fix-500-caused-by-db-desync
branch
3 times, most recently
from
May 4, 2020 07:55
b320b64
to
ac58a7a
Compare
Rename function get_organization_owners_team to get_or_create_organization_owners_team
DavisRayM
force-pushed
the
fix-500-caused-by-db-desync
branch
from
May 4, 2020 08:08
ac58a7a
to
cac43d8
Compare
ivermac
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
AttributeError
raised when retrieving an XForm from the list viewset usingform_pk
.DoesNotExist
error raised when retrieving owner team.Owners
team.Steps taken to verify this change does what is intended
Side effects of implementing this change
Closes #1809
Additional Information: DoesNotExist error, Attribute error