Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where file uploads were automatically soft deleted #1816

Merged
merged 4 commits into from
May 8, 2020
Merged

Fix issue where file uploads were automatically soft deleted #1816

merged 4 commits into from
May 8, 2020

Conversation

DavisRayM
Copy link
Contributor

@DavisRayM DavisRayM commented Apr 20, 2020 •
edited
Loading

Changes / Features implemented

  • Add file to KNOWN_MEDIA_TYPES
  • Update test_replaced_attachments_not_tracked test

Pending Work

  • Add test for recover_deleted_attachments management function

Steps taken to verify this change does what is intended

  • Updated tests
  • QA

Side effects of implementing this change

Closes #1815

@DavisRayM DavisRayM changed the title Fix issue where file uploads were automatically soft deleted [WIP] Fix issue where file uploads were automatically soft deleted Apr 20, 2020
@DavisRayM DavisRayM force-pushed the missing_attachment_list branch 2 times, most recently from d8f81df to 46d2308 Compare April 21, 2020 06:14
@DavisRayM DavisRayM changed the title [WIP] Fix issue where file uploads were automatically soft deleted Fix issue where file uploads were automatically soft deleted Apr 21, 2020
@DavisRayM DavisRayM force-pushed the missing_attachment_list branch 2 times, most recently from 1001529 to 00acb2b Compare April 21, 2020 06:35
ivermac
ivermac previously approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@ivermac ivermac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@DavisRayM DavisRayM force-pushed the missing_attachment_list branch 2 times, most recently from 4f20df3 to 32ef633 Compare April 21, 2020 14:03
@DavisRayM DavisRayM changed the title Fix issue where file uploads were automatically soft deleted [WIP] Fix issue where file uploads were automatically soft deleted Apr 21, 2020
@DavisRayM
Copy link
Contributor Author

Noticed duplicate attachments for new submissions while testing this out, investigating further to see if it's a bug.

@DavisRayM
Copy link
Contributor Author

DavisRayM commented Apr 21, 2020 •
edited
Loading

Noticed duplicate attachments for new submissions while testing this out, investigating further to see if it's a bug.

Not entirely sure what caused this... Unable to replicate it at the moment though.

Might have been one of the previous iterations of the management command

@DavisRayM DavisRayM changed the title [WIP] Fix issue where file uploads were automatically soft deleted Fix issue where file uploads were automatically soft deleted Apr 21, 2020
@ivermac ivermac self-requested a review April 21, 2020 14:11
ivermac
ivermac previously approved these changes Apr 21, 2020
View reviewed changes
@faith-mutua
Copy link

@DavisRayM The attachment list now has the uploaded file. I wonder why we still have the media not uploaded successfully tooltip as shown in the screenshot below.

Screen Shot 2020-04-29 at 13 45 26

@DavisRayM
Copy link
Contributor Author

DavisRayM commented Apr 29, 2020 •
edited
Loading

@faith-mutua That's weird... not entirely sure if that's a bug on the api or the frontend... If the information is returned on the endpoint I think this is an issue on the frontend. I'll try to replicate this.

@DavisRayM The attachment list now has the uploaded file. I wonder why we still have the media not uploaded successfully tooltip as shown in the screenshot below.

Screen Shot 2020-04-29 at 13 45 26

@DavisRayM DavisRayM force-pushed the missing_attachment_list branch 2 times, most recently from b78b9f6 to 87eb85a Compare May 5, 2020 06:22
@DavisRayM
Update replaced attachment test
3d70334 
Update test_replaced_attachments_not_tracked test making sure that file
uploads are properly handled and the soft_deletion feature works as
expected
@DavisRayM
Add file to the KNOWN_MEDIA_TYPES list
ca8b59c
@DavisRayM DavisRayM requested a review from ukanga May 6, 2020 07:15
@DavisRayM DavisRayM added the QA+ PR passed QA testing label May 6, 2020
@faith-mutua
Copy link

@DavisRayM document files are now included under -attachments. The files now have downloadable links on the table tab. This has passed QA.

@DavisRayM DavisRayM merged commit a0b26cf into master May 8, 2020
@DavisRayM DavisRayM deleted the missing_attachment_list branch May 8, 2020 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivermac ivermac ivermac approved these changes

@WinnyTroy WinnyTroy Awaiting requested review from WinnyTroy

@ukanga ukanga Awaiting requested review from ukanga

Assignees
No one assigned
Labels
QA+ PR passed QA testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Files sent alongside a submission are automatically soft_deleted
3 participants
@DavisRayM @faith-mutua @ivermac