Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix caching issues with newly created projects #1819

Merged
merged 6 commits into from
May 8, 2020
Merged

Fix caching issues with newly created projects #1819

merged 6 commits into from
May 8, 2020

Conversation

KipSigei
Copy link
Contributor

@KipSigei KipSigei commented Apr 30, 2020 •
edited
Loading

Changes / Features implemented

  • Fixes the issue where making a GET to the projects endpoint immediately after creating a project throws a 404 because the replica db isn't updated with the newly created project on time.

Steps taken to verify this change does what is intended

  • Tests

Side effects of implementing this change

  • This change will also affect caching project forms, dataviews(filtered datasets) and users

Closes https://github.com/onaio/zebra/issues/5911

@KipSigei KipSigei force-pushed the fix-caching-issue-projects-endpoint branch from 85dea3f to 8719a23 Compare April 30, 2020 07:58
ukanga
ukanga previously approved these changes Apr 30, 2020
View reviewed changes
@KipSigei KipSigei force-pushed the fix-caching-issue-projects-endpoint branch from 8719a23 to 4082d1b Compare April 30, 2020 08:55
ivermac
ivermac reviewed Apr 30, 2020
View reviewed changes
Copy link
Contributor

@ivermac ivermac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a single comment

onadata/apps/api/viewsets/project_viewset.py Show resolved Hide resolved
@KipSigei KipSigei force-pushed the fix-caching-issue-projects-endpoint branch from cc4e53a to d9c88a3 Compare May 4, 2020 16:33
@KipSigei
Fix data view caching bug
5ddc7ac 
Signed-off-by: Kipchirchir Sigei <[email protected]>
@KipSigei KipSigei force-pushed the fix-caching-issue-projects-endpoint branch from 6462740 to 5ddc7ac Compare May 6, 2020 12:18
@KipSigei KipSigei mentioned this pull request May 7, 2020
Closed
ivermac
ivermac approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@ivermac ivermac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ukanga ukanga merged commit d014368 into master May 8, 2020
@ukanga ukanga deleted the fix-caching-issue-projects-endpoint branch May 8, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukanga ukanga ukanga approved these changes

@ivermac ivermac ivermac approved these changes

@DavisRayM DavisRayM Awaiting requested review from DavisRayM

@moshthepitt moshthepitt Awaiting requested review from moshthepitt

@WinnyTroy WinnyTroy Awaiting requested review from WinnyTroy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KipSigei @ukanga @ivermac