Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenData endpoint updates #1820

Merged
merged 5 commits into from
May 26, 2020
Merged

OpenData endpoint updates #1820

merged 5 commits into from
May 26, 2020

Conversation

WinnyTroy
Copy link
Contributor

@WinnyTroy WinnyTroy commented Apr 30, 2020 •
edited
Loading

This approach aims to ensure that the column header fields used to create tableau dashboards match the row header fields

Steps taken

  • Removed metadata field from both the column headers and row headers
  • Include column fields not present in the submission data
  • Flatten repeat data in the submission data.

@WinnyTroy WinnyTroy force-pushed the tableau_fixes branch 2 times, most recently from a754ab4 to 0b62609 Compare May 4, 2020 09:11
@WinnyTroy WinnyTroy force-pushed the tableau_fixes branch 3 times, most recently from 5d48f99 to 58d3cef Compare May 5, 2020 07:03
@WinnyTroy WinnyTroy marked this pull request as ready for review May 5, 2020 08:07
ukanga
ukanga requested changes May 5, 2020
View reviewed changes
onadata/libs/utils/cache_tools.py Outdated Show resolved Hide resolved
onadata/libs/utils/cache_tools.py Outdated Show resolved Hide resolved
@WinnyTroy WinnyTroy force-pushed the tableau_fixes branch 3 times, most recently from 1a20c5e to ced05a8 Compare May 5, 2020 08:47
@WinnyTroy WinnyTroy force-pushed the tableau_fixes branch 2 times, most recently from 79d7df9 to e6dbbba Compare May 7, 2020 11:25
@WinnyTroy WinnyTroy force-pushed the tableau_fixes branch 6 times, most recently from 7813852 to f860858 Compare May 12, 2020 08:42
pld
pld requested changes May 19, 2020
View reviewed changes
onadata/apps/api/viewsets/open_data_viewset.py Outdated Show resolved Hide resolved
onadata/apps/api/viewsets/open_data_viewset.py Outdated Show resolved Hide resolved
onadata/apps/api/viewsets/open_data_viewset.py Outdated Show resolved Hide resolved
onadata/apps/api/viewsets/open_data_viewset.py Outdated Show resolved Hide resolved
onadata/apps/api/viewsets/open_data_viewset.py Outdated Show resolved Hide resolved
onadata/apps/api/viewsets/open_data_viewset.py Outdated Show resolved Hide resolved
onadata/apps/api/viewsets/open_data_viewset.py Show resolved Hide resolved
onadata/libs/serializers/data_serializer.py Outdated Show resolved Hide resolved
onadata/apps/api/viewsets/open_data_viewset.py Outdated Show resolved Hide resolved
onadata/libs/utils/common_tags.py Outdated Show resolved Hide resolved
@WinnyTroy WinnyTroy force-pushed the tableau_fixes branch 6 times, most recently from ac50337 to eefdc31 Compare May 20, 2020 11:03
pld
pld approved these changes May 20, 2020
View reviewed changes
onadata/apps/api/viewsets/open_data_viewset.py Outdated Show resolved Hide resolved
onadata/apps/api/viewsets/open_data_viewset.py Outdated Show resolved Hide resolved
pld
pld requested changes May 20, 2020
View reviewed changes
Copy link
Member

@pld pld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple comments

ukanga
ukanga previously approved these changes May 21, 2020
View reviewed changes
pld
pld previously approved these changes May 21, 2020
View reviewed changes
@DavisRayM DavisRayM merged commit 3368ec5 into master May 26, 2020
@DavisRayM DavisRayM deleted the tableau_fixes branch May 26, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavisRayM DavisRayM DavisRayM left review comments

@ukanga ukanga ukanga left review comments

@pld pld pld left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WinnyTroy @pld @ukanga @DavisRayM