Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to disable creation of public projects and xforms #1829

Merged
merged 1 commit into from
May 26, 2020

Conversation

DavisRayM
Copy link
Contributor

Changes / Features implemented

  • Added new ALLOW_PUBLIC_DATASETS settings
  • Added ability to disable creation of public projects and forms

Steps taken to verify this change does what is intended

Side effects of implementing this change

@DavisRayM DavisRayM requested review from ukanga and ivermac May 26, 2020 11:25
@DavisRayM DavisRayM changed the base branch from v2.3.3-rc to master May 26, 2020 11:34
@DavisRayM DavisRayM force-pushed the add-optional-allow-projects branch 2 times, most recently from 0953b9d to 548bb93 Compare May 26, 2020 11:41
ivermac
ivermac previously approved these changes May 26, 2020
Copy link
Contributor

@ivermac ivermac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

ivermac
ivermac previously approved these changes May 26, 2020
"""
if not settings.ALLOW_PUBLIC_DATASETS and value:
raise serializers.ValidationError(
'Public projects are currently disabled.')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please enable translation support?

_("Public projects are currently disabled.")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let me change that

@DavisRayM DavisRayM merged commit 9f824c4 into master May 26, 2020
@DavisRayM DavisRayM deleted the add-optional-allow-projects branch May 26, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants