Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enketo_meta_usename cookie #1834

Merged
merged 3 commits into from
Jun 17, 2020
Merged

Add enketo_meta_usename cookie #1834

merged 3 commits into from
Jun 17, 2020

Conversation

FrankApiyo
Copy link
Member

Changes / Features implemented

Add __enketo_meta_username cookie with the same value as the enketo_meta_uid cookie

Closes #1832

@FrankApiyo FrankApiyo force-pushed the Issue-1832-add-enketo-cookie branch from 346c7d0 to 582d3f7 Compare June 15, 2020 15:54
DavisRayM
DavisRayM previously approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@DavisRayM DavisRayM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ukanga
ukanga requested changes Jun 16, 2020
View reviewed changes
Copy link
Member

@ukanga ukanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update existing tests to add checks that this is set correctly?

@FrankApiyo FrankApiyo force-pushed the Issue-1832-add-enketo-cookie branch from faa9c74 to 35f9e10 Compare June 17, 2020 11:11
@ukanga ukanga merged commit c4aba58 into master Jun 17, 2020
@ukanga ukanga deleted the Issue-1832-add-enketo-cookie branch June 17, 2020 13:03
@DavisRayM DavisRayM mentioned this pull request Jun 17, 2020
Merged
@faith-mutua
Copy link

@FrankApiyo @DavisRayM This hasn't been fixed yet. I am still getting username not found under the username field on stage.ona.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukanga ukanga ukanga approved these changes

@DavisRayM DavisRayM DavisRayM left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set cookie __enketo_meta_username
4 participants
@FrankApiyo @faith-mutua @ukanga @DavisRayM