Delete User Functionality Updates #1844
Conversation
WinnyTroy
force-pushed
the
Update_settings_crontab
branch
from
4d95d1f
to
9e53807
Compare
onadata/settings/common.py
Outdated
| CELERY_BEAT_SCHEDULE = { | ||
| 'Mark-Expired-Exports-Failed': { | ||
| 'task': | ||
| 'onadata.apps.viewer.tasks.mark_expired_pending_exports_as_failed', | ||
| 'schedule': crontab(hour='*', minute='0'), | ||
| 'options': {'ignore_result': True} | ||
| }, | ||
| 'Delete-Expired-Failed-Exports': { | ||
| 'task': 'onadata.apps.viewer.tasks.delete_expired_failed_exports', | ||
| 'schedule': crontab(hour='*', minute='10'), | ||
| 'options': {'ignore_result': True} | ||
| }, | ||
| 'celery.backend_cleanup': { | ||
| 'task': 'celery.backend_cleanup', | ||
| 'schedule': crontab(hour='*', minute='30'), | ||
| 'options': {'ignore_result': True} | ||
| }, | ||
| 'Delete-Inactive-Users': { | ||
| 'task': 'onadata.apps.api.tasks.delete_user_async', | ||
| 'schedule': crontab( | ||
| 0, 0, day_of_month='30'), # Execute on the 30th of every month. | ||
| 'options': {'ignore_result': True} | ||
| }, | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't think this configuration should be placed within the common settings..... Celery beat scheduling seems like something the user should configure within their own local settings IMO
There was a problem hiding this comment.
Places this here since the tasks are things that should run in all environments/deployments of onadata
Im unsure which settings file would be a better fit for this configurations.
Cc: @ivermac
onadata/settings/common.py
Outdated
| 'Delete-Inactive-Users': { | ||
| 'task': 'onadata.apps.api.tasks.delete_user_async', | ||
| 'schedule': crontab( | ||
| 0, 0, day_of_month='30'), # Execute on the 30th of every month. |
There was a problem hiding this comment.
@WinnyTroy What about the month of February? Can we consider may be the 1st day of every month?
There was a problem hiding this comment.
I agree with @DavisRayM on having the configuration on a user's local settings file
There was a problem hiding this comment.
That said, I like the fact that functionality will be scheduled and executed once a month
There was a problem hiding this comment.
Alright, sure, I'll remove this configurations from here.
And I see no problem with having this run on the 1st of every month. Let me change that
WinnyTroy
force-pushed
the
Update_settings_crontab
branch
2 times, most recently
from
00aa23c
to
5fd0378
Compare
| "User Ken deleted successfully.", | ||
| out.getvalue()) | ||
|
|
||
| with self.assertRaises(ObjectDoesNotExist): |
There was a problem hiding this comment.
Tiny thing/change.... Please use User.DoesNotExist
There was a problem hiding this comment.
Cool cool. Changed that.
WinnyTroy
force-pushed
the
Update_settings_crontab
branch
2 times, most recently
from
7e00fbf
to
d23c866
Compare
WinnyTroy
force-pushed
the
Update_settings_crontab
branch
from
d23c866
to
0690698
Compare
…ally perform task
WinnyTroy
force-pushed
the
Update_settings_crontab
branch
from
0690698
to
96a51d2
Compare
Included deletion suffix to email associated with the user account
Included cron task to periodically perform task after 30 days
Closes #1843