Flexible mqtt topics #1850
Merged
Flexible mqtt topics #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lincmba
force-pushed
the
flexible-mqtt-topics
branch
2 times, most recently
from
add35e2
to
4799710
Compare
lincmba
force-pushed
the
flexible-mqtt-topics
branch
6 times, most recently
from
c7caace
to
2a92a35
Compare
DavisRayM
reviewed
Jul 27, 2020
Comment on lines
713
to
717
| # send form update notification | ||
| send_message( | ||
| instance_id=self.object.id, target_id=self.object.id, | ||
| target_type=XFORM, user=self.request.user, | ||
| message_verb=FORM_UPDATED) |
There was a problem hiding this comment.
Is there a chance that the _try_update_xlsform function might fail?
There was a problem hiding this comment.
Mainly concerned with sending the notification before confirming that the XForm has been updated...
There was a problem hiding this comment.
Makes sense. Made changes
DavisRayM
reviewed
Jul 27, 2020
Comment on lines
+30
to
+33
| # Sometimes the Action isn't created yet, hence | ||
| # the need to delay 2 seconds | ||
| call_backend_async.apply_async( | ||
| (backend, instance.id, backend_options), countdown=2) |
There was a problem hiding this comment.
Why are the actions not created at this point sometimes? Expecting this function to only be called after the Action is saved... and instance should be an Action object right ?
There was a problem hiding this comment.
There was a problem hiding this comment.
Mhh weird... I'm guessing the created boolean was also True at this point?
lincmba
force-pushed
the
flexible-mqtt-topics
branch
2 times, most recently
from
86e513b
to
01b6167
Compare
ukanga
previously approved these changes
Jul 27, 2020
|
@lincmba this has passed QA. A message payload is included for each API json response. |
…each time there is an update to the form yet the notification is only interested in changes in the form xls file itself. For submissions, this isn't called when there is a bulk update of the submissions. Signed-off-by: lincmba <[email protected]>
For submissions: Send notification both upon creation and edit Signed-off-by: lincmba <[email protected]>
Send notification on bulk submission review Signed-off-by: lincmba <[email protected]>
`/onadata/organization/{org_id}/project/{proj_id}/xform/{xform_id}/#`
Signed-off-by: lincmba <[email protected]>
Signed-off-by: lincmba <[email protected]>
Signed-off-by: lincmba <[email protected]>
1. Submission Review 2. Bulk Submission Review 3. CSV upload submission creation 4. CSV Upload submission edit 5. Form update 6. Submission Delete 7. Bulk Submission Delete Signed-off-by: lincmba <[email protected]>
Send message only after successful xls form update
lincmba
force-pushed
the
flexible-mqtt-topics
branch
from
01b6167
to
a9c4cf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Supercedes #1793
Submissions: Send notification both upon creation and edit
/onadata/organization/{org_id}/project/{proj_id}/xform/{xform_id}/#To test
/onadata/organization/[org_username]/project/[proj_id]/xform/[form_id]/submission/deleted/api/v1/messaging.json?target_type=xform&target_id={form_id}&verb=submission_deleted/onadata/organization/[org_username]/project/[proj_id]/xform/[form_id]/submission/created/api/v1/messaging.json?target_type=xform&target_id={form_id}&verb=submission_created/onadata/organization/[org_username]/project/[proj_id]/xform/[form_id]/submission/edited/api/v1/messaging.json?target_type=xform&target_id={form_id}&verb=submission_edited/onadata/organization/[org_username]/project/[proj_id]/xform/[form_id]/submission/reviewed/api/v1/messaging.json?target_type=xform&target_id={form_id}&verb=submission_review/onadata/organization/[org_username]/project/[proj_id]/xform/[form_id]/form/updated/api/v1/messaging.json?target_type=xform&target_id={form_id}&verb=form_updatedExample payload:
{ "id": 113, "verb": "submission_deleted", "message": {"id": ["35838"]}, "user": "linc", "timestamp": "2020-06-10T11:10:45.346353+00:00" }Steps taken to verify this change does what is intended
Written tests
Side effects of implementing this change
Closes #1846