CSV Import: Handle re-importing of select_multiple questions #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisRayM
force-pushed
the
1655-csv-import-error
branch
3 times, most recently
from
c731fb9
to
8b7a44f
Compare
DavisRayM
changed the title
DavisRayM
changed the title
DavisRayM
force-pushed
the
1655-csv-import-error
branch
2 times, most recently
from
b57afa7
to
7f65f4a
Compare
ukanga
reviewed
Aug 3, 2020
Comment on lines
+75
to
+78
| if isinstance(result[k], str) and \ | ||
| k in override_keys: | ||
| result[k] = {} | ||
| result[k] = merge_list_of_dicts([result[k], v]) |
There was a problem hiding this comment.
What should happen in the else part of this check? Should we re-raise the exception or silently ignore as this currently does? Does it mean that an empty submission is made or the row is skipped?
There was a problem hiding this comment.
This would mean the row would be skipped & the previous value would be used on the field. I think re-raising the error and stopping the CSV Import process here would be the best option...
ukanga
previously approved these changes
Aug 4, 2020
|
Complexity increasing per file
==============================
- onadata/libs/utils/dict_tools.py 2
See the complete overview on Codacy |
DavisRayM
force-pushed
the
1655-csv-import-error
branch
from
8692556
to
90675f8
Compare
DavisRayM
force-pushed
the
1655-csv-import-error
branch
3 times, most recently
from
32ffc97
to
a13e705
Compare
DavisRayM
changed the title
DavisRayM
force-pushed
the
1655-csv-import-error
branch
2 times, most recently
from
7829944
to
2eaa305
Compare
The 'AttributeError' is usually raised during the CSV Import process if a user imports a CSV form that has an extra column(usually containing some extra information that may be useful for the users own analysis)
Handle cases where extra details are added on a select_multiple question column
select_multiple keys can have duplicates depending on the number of choices. This change ensures that the 'select_question_keys' list only has one entry for each question key and that the 'meta' key is excluded.
DavisRayM
force-pushed
the
1655-csv-import-error
branch
from
2eaa305
to
5407ec5
Compare
ivermac
approved these changes
Sep 3, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Steps taken to verify this change does what is intended
Side effects of implementing this change
stringvalue passed in theselect_multiplefield is actually useful? Should we store the data in the metadata ?Extra Info
Seems the issue documented in #1655 occurs when a user adds in a column(matching a
select_multiplequestion) for extra information. i.e When using a form such as this and trying to import this kind of dataCloses #1655