Ensure user is either an Admin or Manager before allowing submission reviews #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisRayM
force-pushed
the
submission-review-require-admin-privileges
branch
4 times, most recently
from
b60bb50
to
89ad7a8
Compare
DavisRayM
changed the title
DavisRayM
commented
Aug 7, 2020
Comment on lines
+169
to
+170
| return OwnerRole.user_has_role( | ||
| user, xform) or ManagerRole.user_has_role(user, xform) |
There was a problem hiding this comment.
Should project managers still be able to create, update & delete submission reviews?
DavisRayM
force-pushed
the
submission-review-require-admin-privileges
branch
from
89ad7a8
to
846facd
Compare
ukanga
previously approved these changes
Aug 7, 2020
Comment on lines
+169
to
+170
| return OwnerRole.user_has_role( | ||
| user, xform) or ManagerRole.user_has_role(user, xform) |
DavisRayM
force-pushed
the
submission-review-require-admin-privileges
branch
from
846facd
to
acb77f4
Compare
ivermac
approved these changes
Aug 10, 2020
Comment on lines
+204
to
+206
| # Editors should not be able to create, update, delete | ||
| # reviews. Only Admins and Managers should have these permissions | ||
| EditorRole.add(self.user, form) |
There was a problem hiding this comment.
The irony of the role title and the update functionality 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
SubmissionReviewmodel.Steps taken to verify this change does what is intended
Side effects of implementing this change
Closes #1866