Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate records after edit #1869

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Conversation

DavisRayM
Copy link
Contributor

@DavisRayM DavisRayM commented Aug 10, 2020

Changes / Features implemented

  • Set instanceID in submission XML when creating

Steps taken to verify this change does what is intended

  • Updated test
  • QA

Side effects of implementing this change

  • N/A

Extra Info

Without the instanceID in the XML, Enketo generates a new instanceID which instead of editing the original it creates another one. Setting the instanceID ensures that the correct submission is edited.

Closes #1868

@DavisRayM DavisRayM changed the base branch from master to v2.3.7-rc August 10, 2020 12:56
@DavisRayM DavisRayM force-pushed the created-submissions-instance-id branch from 6223ad7 to db0a261 Compare August 10, 2020 13:00
@DavisRayM DavisRayM added the QA+ PR passed QA testing label Aug 10, 2020
Copy link
Contributor

@ivermac ivermac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@DavisRayM DavisRayM force-pushed the created-submissions-instance-id branch from 61230ea to 2bd4365 Compare August 10, 2020 14:32
@DavisRayM DavisRayM force-pushed the created-submissions-instance-id branch from 2bd4365 to c3ad162 Compare August 10, 2020 15:09
@DavisRayM DavisRayM merged commit c62704c into v2.3.7-rc Aug 10, 2020
@DavisRayM DavisRayM deleted the created-submissions-instance-id branch August 10, 2020 20:14
DavisRayM added a commit that referenced this pull request Aug 11, 2020
* Bump version to v2.3.7
* Fix duplicate records after edit (#1869)
* Update CHANGES.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA+ PR passed QA testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Records Get Duplicated after Editing
3 participants