-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for tracking submissions with Segment #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisRayM
changed the title
Initial support for tracking submissions with Segment
[WIP] Initial support for tracking submissions with Segment
Aug 12, 2020
DavisRayM
force-pushed
the
analytics
branch
11 times, most recently
from
August 14, 2020 14:24
2db3bcb
to
5ebbffd
Compare
DavisRayM
force-pushed
the
analytics
branch
5 times, most recently
from
August 26, 2020 17:13
efc44ea
to
0b68e20
Compare
DavisRayM
force-pushed
the
analytics
branch
3 times, most recently
from
August 27, 2020 06:50
1f3999c
to
636a798
Compare
DavisRayM
changed the title
[WIP] Initial support for tracking submissions with Segment
Initial support for tracking submissions with Segment
Aug 27, 2020
ukanga
approved these changes
Aug 27, 2020
ivermac
approved these changes
Aug 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DavisRayM, I just wanted to mention that I really like the way you have made use of the class decorators which is very clean and easy to use. Good job on this 👍 !
This was referenced Aug 28, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1871
Changes / Features implemented