Add caching to the organization profile viewset #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
FrankApiyo
force-pushed
the
add-organization-and-user-profile-caching
branch
4 times, most recently
from
2884a9b
to
1980f67
Compare
FrankApiyo
changed the title
DavisRayM
reviewed
Aug 24, 2020
| """ | ||
| Specific to clear cache between tests | ||
| """ | ||
| cache.clear() |
There was a problem hiding this comment.
I think we should also call super(self.__class__, self).tearDown()... In case the inherited class also has some custom tearDown functionality maybe?
FrankApiyo
force-pushed
the
add-organization-and-user-profile-caching
branch
2 times, most recently
from
51ebf7e
to
2b04753
Compare
FrankApiyo
requested review from
DavisRayM and
pld
and removed request for
pld
FrankApiyo
force-pushed
the
add-organization-and-user-profile-caching
branch
from
2b04753
to
44c7da6
Compare
ivermac
approved these changes
Aug 26, 2020
This was referenced Aug 28, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1879
Changes introduced in this PR