Add support for login with email/password on the classic login pages #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisRayM
force-pushed
the
allow-email-login-classic-template
branch
from
92506fa
to
bc57393
Compare
ivermac
previously approved these changes
Aug 21, 2020
ukanga
reviewed
Aug 21, 2020
onadata/apps/main/backends.py
Outdated
| Username is case insensitive. Supports using email in place of username | ||
| """ | ||
| user = User.objects.filter( | ||
| Q(username__iexact=username) | Q(email=username)).first() |
There was a problem hiding this comment.
I think we should also use email__iexact=email, it sometimes is written differently by different people.
There was a problem hiding this comment.
Agreed, changed this in the latest commit.
DavisRayM
force-pushed
the
allow-email-login-classic-template
branch
from
bc57393
to
ab40c17
Compare
ivermac
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Steps taken to verify this change does what is intended
Side effects of implementing this change
Closes #1789