Tableau unpack gps data into altitude, precision, latitude and longitude columns #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WinnyTroy
force-pushed
the
tableau_unpack_gps_data
branch
from
8238f10
to
4e40364
Compare
DavisRayM
reviewed
Aug 25, 2020
| '-1.2625621') | ||
| self.assertEqual( | ||
| row_data[0]['_gps_longitude'], | ||
| '36.7921711') |
There was a problem hiding this comment.
Should we also assert that the altitude and precision values are correct ?
ivermac
previously approved these changes
Aug 26, 2020
WinnyTroy
force-pushed
the
tableau_unpack_gps_data
branch
from
4e40364
to
8a15303
Compare
|
Complexity increasing per file
==============================
- onadata/apps/api/viewsets/open_data_viewset.py 3
See the complete overview on Codacy |
DavisRayM
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps taken to verify this change does what is intended
Side effects of implementing this change
None
Closes #1877
Closes #1777