Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generation of enketo edit urls #1887

Merged
merged 3 commits into from
Sep 3, 2020
Merged

Fix generation of enketo edit urls #1887

merged 3 commits into from
Sep 3, 2020

Conversation

DavisRayM
Copy link
Contributor

@DavisRayM DavisRayM commented Sep 3, 2020

Changes / Features implemented

  • Use instance_id and instance_xml when generating edit url

Steps taken to verify this change does what is intended

  • Update tests
  • QA

Side effects of implementing this change

  • N/A

@DavisRayM DavisRayM marked this pull request as ready for review September 3, 2020 06:53
@DavisRayM DavisRayM requested review from WinnyTroy and ivermac and removed request for WinnyTroy September 3, 2020 06:56
ivermac
ivermac previously approved these changes Sep 3, 2020
@DavisRayM DavisRayM merged commit a39cc05 into master Sep 3, 2020
@DavisRayM DavisRayM deleted the enketo-edit-fix branch September 3, 2020 08:26
@DavisRayM DavisRayM mentioned this pull request Sep 3, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants