Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit message payload sizes #1893

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Limit message payload sizes #1893

merged 1 commit into from
Sep 10, 2020

Conversation

DavisRayM
Copy link
Contributor

@DavisRayM DavisRayM commented Sep 8, 2020 •
edited
Loading

Changes / Features implemented

  • Limit the number of IDs present in a message payload; Chunk huge message payloads.

Steps taken to verify this change does what is intended

  • Added tests

Side effects of implementing this change

  • Notifications with a lot of affected IDs will now be split into chunks. Consumers of the notifications may need to take this into account.

Closes #1892

@pld Codacy Production
Copy link
Member

pld commented Sep 8, 2020

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- onadata/apps/messaging/tests/test_utils.py  2

See the complete overview on Codacy

ivermac
ivermac approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@ivermac ivermac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! It would be interesting to see this in action based on the convo we had earlier today

@DavisRayM DavisRayM merged commit f56ff0d into master Sep 10, 2020
@DavisRayM DavisRayM deleted the mqtt-payload-limit branch September 10, 2020 07:26
@DavisRayM DavisRayM mentioned this pull request Sep 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivermac ivermac ivermac approved these changes

@WinnyTroy WinnyTroy WinnyTroy approved these changes

@lincmba lincmba Awaiting requested review from lincmba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chunk notification payloads after a certain threshold
4 participants
@DavisRayM @pld @ivermac @WinnyTroy