Project Viewset: Caching refactor #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivermac
previously approved these changes
Sep 23, 2020
| """ | ||
| Clears and sets project cache | ||
| """ | ||
| from onadata.libs.serializers.project_serializer import ProjectSerializer |
There was a problem hiding this comment.
I'm going to assume we had to import here because of cyclic import error, no?
There was a problem hiding this comment.
Yes, this is here to avoid a cyclic import error
In some cases publish_form returns a dict containing an error message as such we should only reset the project cache when an XForm is returned
DavisRayM
force-pushed
the
handle-stale-cache-in-project-endpoint
branch
from
a053821
to
c71a3b5
Compare
DavisRayM
changed the title
DavisRayM
force-pushed
the
handle-stale-cache-in-project-endpoint
branch
from
c71a3b5
to
90f2c19
Compare
The Project viewset cache should be cleared if one of it's XForms or Submissions have had an update to their data so that stale responses are not returned
DavisRayM
force-pushed
the
handle-stale-cache-in-project-endpoint
branch
from
90f2c19
to
cbc56e1
Compare
|
Clones added
============
- onadata/apps/api/tests/viewsets/test_project_viewset.py 6
See the complete overview on Codacy |
DavisRayM
changed the title
ivermac
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
num_datasetsvalue of a project was not updated when a form that used to belong to that form is transferredreset_project_cacheutility functionSteps taken to verify this change does what is intended
Side effects of implementing this change
Closes #1903