Dockerfile updates #1937
Dockerfile updates #1937
Conversation
DavisRayM
force-pushed
the
docker-build-changes
branch
2 times, most recently
from
4f4fe83
to
d7bf935
Compare
|
Issues
======
- Added 2
See the complete overview on Codacy |
docker/onadata-uwsgi/Dockerfile
Outdated
| RUN ssh-keyscan github.com > /root/.ssh/known_hosts | ||
|
|
||
| # Install optional requirements | ||
| RUN if [ ! -z "$optional_packages" ]; then pip install ${optional_packages} ; fi |
There was a problem hiding this comment.
Codacy found an issue: Pin versions in pip. Instead of pip install <package> use pip install <package>==<version>
docker/onadata-uwsgi/Dockerfile
Outdated
| RUN ssh-keyscan github.com > /root/.ssh/known_hosts | ||
|
|
||
| # Install optional requirements | ||
| RUN if [ ! -z "$optional_packages" ]; then pip install ${optional_packages} ; fi |
There was a problem hiding this comment.
Codacy found an issue: Use -n instead of ! -z.
DavisRayM
force-pushed
the
docker-build-changes
branch
2 times, most recently
from
c1edd52
to
8a9cabf
Compare
| build: | ||
| context: . | ||
| dockerfile: Dockerfile | ||
| image: onadata:latest | ||
| volumes: | ||
| # For local development | ||
| - ../../.:/srv/onadata | ||
| image: onaio/onadata:latest |
There was a problem hiding this comment.
The point about doing local builds was for development purposes. In my last years of writing code on this repositories this has been the primary way my dev environment worked, from within the container. Perhaps add a docker-compose.prod.yml file instead?
|
|
||
| jobs: | ||
| main: | ||
| runs-on: ubuntu-18.04 |
There was a problem hiding this comment.
I believe we can. I'll modify the Dockerfile to use 20.04 as the base image and test it out
DavisRayM
force-pushed
the
docker-build-changes
branch
from
b1cc1e6
to
cb28754
Compare
DavisRayM
force-pushed
the
docker-build-changes
branch
from
de26c2b
to
996cab2
Compare
Changes / Features implemented
docker-image-build.ymlgithub workflowSteps taken to verify this change does what is intended