Add enketo-preview url routed to PreviewXFormListViewSet #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankApiyo
force-pushed
the
fix-1952-add-enketo-preview-endpoint
branch
from
a22ce7b
to
1dcabba
Compare
ukanga
reviewed
Nov 25, 2020
There was a problem hiding this comment.
Just concerned we do not have test to perhaps check this will work as expected Perhaps in onadata/apps/api/tests/viewsets/test_xform_list_viewset.py as was the case when we introduced the /enketo path.
ukanga
previously approved these changes
Nov 25, 2020
ukanga
reviewed
Nov 25, 2020
There was a problem hiding this comment.
Could we also add some documentation in the docs for this new endpoint as well perhaps on the enketo endpoint. Check with @DavisRayM on the full docs for both endpoints.
FrankApiyo
force-pushed
the
fix-1952-add-enketo-preview-endpoint
branch
4 times, most recently
from
5d8aaf3
to
b742e8e
Compare
FrankApiyo
requested review from
ivermac and
ukanga
and removed request for
WinnyTroy
FrankApiyo
force-pushed
the
fix-1952-add-enketo-preview-endpoint
branch
from
b742e8e
to
3b7250c
Compare
ivermac
suggested changes
Dec 3, 2020
docs/formlist.rst
Outdated
| ^^^^^^^ | ||
| :: | ||
|
|
||
| curl -X GET https://stage-api.ona.io/<user_name>/<form_pk>/formList |
There was a problem hiding this comment.
Can we use api.ona.io on our example urls?
docs/formlist.rst
Outdated
|
|
||
| :: | ||
|
|
||
| curl -X GET https://stage-api.ona.io/enketo/<form_pk>/formList |
docs/formlist.rst
Outdated
|
|
||
| :: | ||
|
|
||
| curl -X GET https://stage-api.ona.io/enketo-preview/<form_pk>/formList |
@ivermac yes! https://github.com/onaio/onadata/blob/master/onadata/apps/api/viewsets/xform_list_viewset.py#L167 |
FrankApiyo
force-pushed
the
fix-1952-add-enketo-preview-endpoint
branch
from
3b7250c
to
ecf26ab
Compare
ivermac
approved these changes
Dec 3, 2020
ukanga
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Add a new URL that is routed to
PreviewXFormListViewSetSteps taken to verify this change does what is intended
This has been tested on the staging environment and works as expected
Closes #1952