Data viewset retrieval optimisations #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisRayM
force-pushed
the
data-retrieval-improvements
branch
from
a27d91a
to
9a439c0
Compare
ivermac
reviewed
Dec 9, 2020
| deleted_at__isnull=True).values_list('id', flat=True) | ||
| num_of_submissions = sum( | ||
| merged_form.xforms.values_list( | ||
| 'num_of_submissions', flat=True)) |
There was a problem hiding this comment.
Should the above also filter by deleted_at is not null i.e.
merged_form.xforms.filter(deleted_at__isnull=True).values_list('num_of_submissions', flat=True)If the above is true, can the query in line 417 and 420 be merged into 1 to retrieve both the id and num_of_submissions ?
Comment on lines
428
to
434
| # Disable ordering for XForms with Submissions that are more | ||
| # than the SUBMISSION_RETRIEVAL_THRESHOLD |
There was a problem hiding this comment.
Or
# Enable ordering for XForms with Submissions that are less
# than the SUBMISSION_RETRIEVAL_THRESHOLD😄
…tion" classes The two classes are custom classes derived from the Django's Paginator and RestFrameworks' PageNumberPagination that allow the count property on the paginator to be overriden by a passed in value
Disable ETag functionality for forms that have submissions that surpass the "SUBMISSION_RETRIEVAL_THRESHOLD" setting
DavisRayM
force-pushed
the
data-retrieval-improvements
branch
3 times, most recently
from
9116add
to
1412968
Compare
Disable submission ordering when a Form has submissions that surpass a configurable "SUBMISSION_RETRIEVAL_THRESHOLD" limit
… for the data viewset
DavisRayM
force-pushed
the
data-retrieval-improvements
branch
from
1412968
to
7bdd4f5
Compare
ivermac
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
SUBMISSION_RETRIEVAL_THRESHOLDsettingSUBMISSION_RETRIEVAL_THRESHOLDsettingSUBMISSION_RETRIEVAL_THRESHOLDsettingCountOverridablePaginatorandCountOverridablePageNumberPaginationCountOverridablePageNumberPaginationTODO
Steps taken to verify this change does what is intended
Side effects of implementing this change