Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp filter for the Messaging ViewSet #1973

Merged
merged 6 commits into from
Dec 18, 2020

Conversation

DavisRayM
Copy link
Contributor

@DavisRayM DavisRayM commented Dec 17, 2020

Changes / Features implemented

  • Add timestamp as a filter

Steps taken to verify this change does what is intended

  • Added Tests

Side effects of implementing this change

  • N/A

Closes #1870

@DavisRayM DavisRayM changed the title Add timestamp filter for the Messaging Viewset [WIP] Add timestamp filter for the Messaging Viewset Dec 17, 2020
@DavisRayM DavisRayM changed the title [WIP] Add timestamp filter for the Messaging Viewset Add timestamp filter for the Messaging ViewSet Dec 17, 2020
ivermac
ivermac previously approved these changes Dec 17, 2020
Copy link
Contributor

@ivermac ivermac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! It would be nice it @ukanga checks out this PR as well

onadata/apps/messaging/filters.py Outdated Show resolved Hide resolved
@DavisRayM DavisRayM merged commit 0af9d5f into master Dec 18, 2020
@DavisRayM DavisRayM deleted the messaging-timestamp-filter branch December 18, 2020 07:53
@DavisRayM DavisRayM mentioned this pull request Jan 20, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add time filter to messages API
3 participants