1990 validate input fields on put form endpoint requests #1991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Ekisa <[email protected]>
Check that error is triggered when version is invalid and description is sanitize if it has html tag characters Signed-off-by: Mark Ekisa <[email protected]>
pld
previously approved these changes
Jan 12, 2021
|
not sure what's up w/the nonetype errors in build but flake8 error is easy to fix |
ukanga
previously approved these changes
Jan 12, 2021
ukanga
reviewed
Jan 12, 2021
Signed-off-by: Mark Ekisa <[email protected]>
ivermac
force-pushed
the
1990-validate-input-fields-on-PUT-form-endpoint-requests
branch
from
ab05b64
to
f4fc180
Compare
DavisRayM
approved these changes
Jan 13, 2021
ivermac
deleted the
1990-validate-input-fields-on-PUT-form-endpoint-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Validate form version and sanitize form description
Steps taken to verify this change does what is intended
Added checks in a test to validate form versions don't have invalid characters and ensure form description with html tag characters are sanitized
Side effects of implementing this change
Closes #1990
Fixed has been inspired by https://devstringx-technologies.medium.com/html-injection-f1c9fc713d51