Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use master database when updating XForm Submission Count #2002

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

DavisRayM
Copy link
Contributor

Changes / Features implemented

  • Avoids cases where the signal is fired before a read replica catches
    up to the main database

Steps taken to verify this change does what is intended

Side effects of implementing this change

Closes #1987

- Avoids cases where the signal is fired before a read replica catches
  up to the main database
@DavisRayM DavisRayM force-pushed the 1987-num-of-submissions-inconsistency branch from 9061873 to ea8354b Compare January 25, 2021 12:46
@DavisRayM DavisRayM changed the title [WIP] Use master database when updating XForm Submission Count Use master database when updating XForm Submission Count Jan 27, 2021
Copy link
Contributor

@ivermac ivermac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@DavisRayM DavisRayM merged commit 7e77fa1 into master Jan 27, 2021
@DavisRayM DavisRayM deleted the 1987-num-of-submissions-inconsistency branch January 27, 2021 09:29
@DavisRayM DavisRayM mentioned this pull request Feb 23, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect submission count on XForms
2 participants