Capture attachment file names whose name exceeds 100 chars #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisRayM
previously approved these changes
Jan 25, 2021
ivermac
reviewed
Jan 27, 2021
onadata/libs/utils/logger_tools.py
Outdated
| @@ -336,6 +336,10 @@ def save_attachments(xform, instance, media_files, remove_deleted_media=False): | |||
| xform.instances_with_osm = True | |||
| xform.save() | |||
| filename = os.path.basename(f.name) | |||
| # Validate Attachment file name length | |||
| if len(filename) > 99: | |||
There was a problem hiding this comment.
Based on the error message, should the number in the condition be 100 instead of 99? At the moment, if the size of the filename is 100, the error message will be triggerd, no?
WinnyTroy
force-pushed
the
user_friendly_attachment_error_name
branch
from
b41f0fc
to
8278680
Compare
WinnyTroy
force-pushed
the
user_friendly_attachment_error_name
branch
2 times, most recently
from
db9e897
to
55e6720
Compare
DavisRayM
approved these changes
Feb 3, 2021
DavisRayM
suggested changes
Feb 3, 2021
onadata/libs/utils/logger_tools.py
Outdated
Comment on lines
341
to
342
| raise AttachmentNameError( | ||
| _('Attachment file name exceeds 100 characters')) |
There was a problem hiding this comment.
Let's ensure this exception is caught and an appropriate status code is returned with the reason.
WinnyTroy
force-pushed
the
user_friendly_attachment_error_name
branch
from
55e6720
to
055d7c5
Compare
WinnyTroy
force-pushed
the
user_friendly_attachment_error_name
branch
from
055d7c5
to
f068dfa
Compare
WinnyTroy
force-pushed
the
user_friendly_attachment_error_name
branch
from
f068dfa
to
f0fb07d
Compare
DavisRayM
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Steps taken to verify this change does what is intended
Closes #1939