Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pagination & xml support to the data list endpoint #2005

Merged
merged 11 commits into from
Feb 2, 2021
Merged

Add pagination & xml support to the data list endpoint #2005

merged 11 commits into from
Feb 2, 2021

Conversation

DavisRayM
Copy link
Contributor

@DavisRayM DavisRayM commented Jan 27, 2021 •
edited
Loading

Changes / Features implemented

  • Add InstanceXMLRenderer class
  • Add DataInstanceXMLSerializer class
  • Add support for XML rendering & pagination on the /api/v1/data endpoint

Pending:

  • Support streaming XML data

Steps taken to verify this change does what is intended

Side effects of implementing this change

Closes #2000

@DavisRayM
Install xmltodict package
dde2ac7
@DavisRayM
Test that it's possible to request the data list in XML Format
f2df719
@DavisRayM
Add DataInstanceXMLSerializer Class
bc2766c 
This Serializer class serializes an `Instance` object into a format
that's renderable by an XMLRenderer
@DavisRayM
Add InstanceXMLRenderer class
4d2b192 
Custom renderer used to render Instance data serialized by the
DataInstanceXMLSerializer
@DavisRayM DavisRayM changed the title [WIP] Add pagination & xml support to the data list endpoint Add pagination & xml support to the data list endpoint Jan 28, 2021
@DavisRayM DavisRayM changed the title Add pagination & xml support to the data list endpoint [WIP] Add pagination & xml support to the data list endpoint Jan 28, 2021
ivermac
ivermac previously approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@ivermac ivermac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@DavisRayM
Add serverTime attribute to root level tag
79d5442 
- Change root level tag name to 'submission-batch'
@DavisRayM DavisRayM changed the title [WIP] Add pagination & xml support to the data list endpoint Add pagination & xml support to the data list endpoint Jan 29, 2021
ivermac
ivermac previously approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@ivermac ivermac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

ivermac
ivermac approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@ivermac ivermac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@DavisRayM DavisRayM merged commit 871f13b into master Feb 2, 2021
@DavisRayM DavisRayM deleted the 2000-data-endpoint-xml branch February 2, 2021 06:46
@DavisRayM DavisRayM mentioned this pull request Feb 2, 2021
Closed
@DavisRayM DavisRayM mentioned this pull request Feb 23, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivermac ivermac ivermac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data Endpoint: Support pagination of XML Response
2 participants
@DavisRayM @ivermac