2006 trigger error on url in xform title #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivermac
force-pushed
the
2006-trigger-error-on-url-in-xform-title
branch
2 times, most recently
from
e28c0ae
to
e7c43c4
Compare
DavisRayM
previously approved these changes
Feb 1, 2021
onadata/apps/logger/models/xform.py
Outdated
|
|
||
| if re.match(pattern, self.title): | ||
| raise XLSFormError( | ||
| _("Invalid title value; shouldn't matches a url")) |
There was a problem hiding this comment.
Suggested change
| _("Invalid title value; shouldn't matches a url")) | |
| _("Invalid title value; value shouldn't match a URL")) |
onadata/apps/logger/models/xform.py
Outdated
| @@ -818,6 +818,13 @@ def _set_title(self): | |||
| _("Title shouldn't have any invalid xml " | |||
| "characters ('>' '&' '<')")) | |||
|
|
|||
| pattern = str("http[s]?://(?:[a-zA-Z]|[0-9]|[$-_@.&+]|" | |||
There was a problem hiding this comment.
Should we update the pattern to also match URLs that don't include the HTTP/HTTPS protocols?
There was a problem hiding this comment.
Yes we should. Let me update
ivermac
force-pushed
the
2006-trigger-error-on-url-in-xform-title
branch
2 times, most recently
from
d1eaa24
to
94868a7
Compare
Signed-off-by: Mark Ekisa <[email protected]>
Co-authored-by: Mark Ekisa <[email protected]>
ivermac
force-pushed
the
2006-trigger-error-on-url-in-xform-title
branch
from
94868a7
to
14b0c2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Trigger error when xform title matches a url
Steps taken to verify this change does what is intended
Added a test to check that an error is triggered when xform title matches a url
Side effects of implementing this change
Closes #2006