Paginate data list responses after a configurable threshold #2010
Conversation
DavisRayM
force-pushed
the
2008-data-list-default-limit
branch
from
0afc725
to
1220ff8
Compare
DavisRayM
changed the title
DavisRayM
changed the title
| pagination_keys = [self.paginator.page_query_param, | ||
| self.paginator.page_size_query_param] | ||
| query_param_keys = self.request.query_params | ||
| should_paginate = any([k in query_param_keys for k in pagination_keys]) | ||
|
|
||
| if not should_paginate and not is_public_request: |
There was a problem hiding this comment.
Does this mean we will not paginate public forms that exceed the threshold?
There was a problem hiding this comment.
At the moment yes; didn't think of this while implementing the feature... Any thoughts/reservations with always paginating public requests? Seems a bit painful to calculate the entire count(getting all public XForms and summing the num_of_submissions) of public data that's currently available...
There was a problem hiding this comment.
This is for a single form request at a time, not all public forms at the same. Also, we could go with num_of_submissions that is not calculated on the fly, it is a safe estimate in most situations.
There was a problem hiding this comment.
I withdraw my statement, I see that is_public_request represents access to the /api/v1/data/public and not to one single form data.
DavisRayM
changed the title
DavisRayM
changed the title
Changes / Features implemented
Steps taken to verify this change does what is intended
Side effects of implementing this change
Closes #2008