Merge select one and select multiple options at MergedXform creation #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankApiyo
changed the title
FrankApiyo
force-pushed
the
charts-endpoint-hotfix
branch
from
e8c892b
to
efe5224
Compare
FrankApiyo
changed the title
FrankApiyo
changed the title
FrankApiyo
force-pushed
the
charts-endpoint-hotfix
branch
from
efe5224
to
775e2d9
Compare
FrankApiyo
changed the title
FrankApiyo
force-pushed
the
charts-endpoint-hotfix
branch
6 times, most recently
from
90c58b4
to
322fc88
Compare
DavisRayM
previously approved these changes
Feb 22, 2021
ivermac
reviewed
Feb 22, 2021
Comment on lines
90
to
92
| if element_list: | ||
| element = element_list[0] | ||
| children += element['children'] |
There was a problem hiding this comment.
For line 92, is it correct to assume that element will always be a non-empty dictionary with a children key? What would happen in line 92 if element_list in line 90 is empty?
There was a problem hiding this comment.
going to change these lines to
if element_list and element_list[0]:
children += element_list[0]['children']
65333db
to
8dfa439
Compare
This also reverts: b6b0343
FrankApiyo
force-pushed
the
charts-endpoint-hotfix
branch
from
8dfa439
to
14ea161
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2016
Changes proposed
select oneandselect multipleoptions at MergedXform creation(in the serializer). This is better because it would work for all the endpoints that make use of these options (not only the charts endpoint)NB: Earlier added tests for the charts endpoints and all existing test should still pass