Fix Charts endpoint JSON response not rendering #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivermac
approved these changes
Feb 25, 2021
| @@ -473,7 +473,7 @@ def get_chart_data_for_field(field_name, | |||
| except DataError as e: | |||
| raise ParseError(text(e)) | |||
| else: | |||
| if accepted_format == 'json': | |||
| if accepted_format == 'json' or not accepted_format: | |||
There was a problem hiding this comment.
Why do we need or not accepted_format?
There was a problem hiding this comment.
Sometimes the format kwarg is empty; the format kwarg is the value we use to determine what type of response to return(but by default we return JSON)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
xformdata key to the XForm ID when noaccepted_formatis givenSteps taken to verify this change does what is intended
Side effects of implementing this change
xformvalue shall be the ID