Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Different root node name" issue #2029

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Fix "Different root node name" issue #2029

merged 1 commit into from
Mar 2, 2021

Conversation

DavisRayM
Copy link
Contributor

@DavisRayM DavisRayM commented Mar 2, 2021 •
edited
Loading

Changes / Features implemented

  • Return data without modification if data is not a list; Avoids encapsulating the XML within the submission-batch root tag

Steps taken to verify this change does what is intended

  • Q/A

Side effects of implementing this change

  • N/A

Closes #

@DavisRayM DavisRayM changed the title Fix Fix "Different root node name" issue Mar 2, 2021
@DavisRayM DavisRayM requested a review from ivermac March 2, 2021 07:25
ivermac
ivermac approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@ivermac ivermac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@DavisRayM DavisRayM merged commit ecd65e6 into master Mar 2, 2021
@DavisRayM DavisRayM deleted the data-detail-page-renderer-fixes branch March 2, 2021 08:02
@DavisRayM DavisRayM mentioned this pull request Mar 2, 2021
Closed
1 task
@WinnyTroy WinnyTroy mentioned this pull request Mar 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivermac ivermac ivermac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavisRayM @ivermac