2037 add review date

[WinnyTroy]

Changes / Features implemented

Adds submission review dates to data endpoint response

Steps taken to verify this change does what is intended

Updated tests
QA

Closes #2037

[ukanga]

Seems the None portion is not being tested, it could be a source of potential bug, I would expect 3 None's to be returned.

[ukanga]

I tend to be hesitant in renaming functions that have been around for a long time, in this case about 3 years. I would perhaps recommend a new method:

def get_latest_review(self):
    try:
        return self.reviews.latest('date_modified')
    except SubmissionReview.DoesNotExist:
        return None

Which then we can use as

review = self.get_latest_review()
if review:
    doc[REVIEW_STATUS] = review.status
    doc[REVIEW_COMMENT] = review.get_note_text() or ""
    doc[REVIEW_DATE] = review.date_created.strftime(MONGO_STRFTIME)

I think this approach is much cleaner and clearer.

[ukanga]

It also means you do not end up having to rename old functions, you could mark the old function deprecated so that we eventually change its reference everywhere.

[DavisRayM]

I wonder if we should use something like the Deprecated library or a custom decorator like this; to mark deprecated functions ?

TODOs usually get forgotten IMO

[WinnyTroy]

Thanks for this.
I've used the pip deprecated package for this. Seemed cleaner.