Fix submission deletion endpoint error #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniswambua
previously approved these changes
Apr 30, 2021
Remove assertion statement that checked whether Instance and Submission Review date_created fields were the same; Instances & Submission Reviews are two different entities and are not created at the same time as such asserting that the date_created is the same between the two will not always pass.
- Assert returned response is equal to the stored Instance JSON
DavisRayM
force-pushed
the
2056-submission-deletion-error
branch
from
c4cfade
to
abec361
Compare
denniswambua
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
send_messageSteps taken to verify this change does what is intended
Side effects of implementing this change
Closes #2056