Update requirements #2070
Merged
Update requirements #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisRayM
force-pushed
the
update-requirements
branch
5 times, most recently
from
0af4dfb
to
a86be14
Compare
DavisRayM
force-pushed
the
update-requirements
branch
from
a958861
to
3bba603
Compare
denniswambua
previously approved these changes
May 20, 2021
PyJWT no longer supports python2 and now returns strings as return values
Ensure function accepts all necessary arguements
The organization field is currently not used for any purpose within the ProjectSerializer and causes a `UniqueTogether` error when included in the serializer alongside the `owner` field.
Expected an error on the `owner` field to be raised instead of an error on the organization field
DavisRayM
force-pushed
the
update-requirements
branch
from
3bba603
to
97c5895
Compare
denniswambua
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
organizationproject serializer field; The field was not being used for any apparent purpose as theownerfield already maps directly to theorganization. Including theorganizationas awrite_onlyfield caused issues since it tried to enforce aUniqueTogethervalidation on a non existentownermodel field.decode()call. PyJWTsdecodefunction now returns stringsbuild_json_resource_objfunction; Include newserializerarguementSteps taken to verify this change does what is intended
Side effects of implementing this change
N/A
Before submitting this PR for review, please make sure you have:
Closes #2048