Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure project owners are able to view all their collaborators from the project list #2073

Merged
merged 6 commits into from
May 7, 2021

Conversation

DavisRayM
Copy link
Contributor

@DavisRayM DavisRayM commented May 7, 2021

Changes / Features implemented

  • Test that project owners are able to see a list of all the users their project has been shared too

Steps taken to verify this change does what is intended

  • Updated tests

Side effects of implementing this change

Users with manager or owner level permissions will now be able to view all the users the project has been shared to

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #2069

Test that project owners are able to see a list of all the users their
project has been shared too
@DavisRayM DavisRayM force-pushed the 2069-project-owner-collaborator-list branch from 10c8961 to 12fb37d Compare May 7, 2021 07:25
Test that project managers are able to view all users a project has been
shared to
Allow project managers and owners to view all users the project is
shared to
@DavisRayM DavisRayM changed the title [WIP] Ensure project owners are able to view all their collaborators from the project list Ensure project owners are able to view all their collaborators from the project list May 7, 2021
Remove test that ensures collaborators are not listed when an owner
makes a request to the project list endpoint without the `owner`
query param
denniswambua
denniswambua previously approved these changes May 7, 2021
@DavisRayM DavisRayM merged commit f12b1c8 into master May 7, 2021
@DavisRayM DavisRayM deleted the 2069-project-owner-collaborator-list branch May 7, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some collaborators missing in project users
2 participants