Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if user is an AnonymousUser before trying to retrieve their project role #2084

Merged
merged 3 commits into from
May 21, 2021
Merged

Check if user is an AnonymousUser before trying to retrieve their project role #2084

merged 3 commits into from
May 21, 2021

Conversation

DavisRayM
Copy link
Contributor

Changes / Features implemented

  • Test that anonymous users are able to list all public projects
  • Check if the user is an anonymous user before retrieving their project role

Steps taken to verify this change does what is intended

  • Updated tests

Side effects of implementing this change

  • N/A

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #2082

@DavisRayM
Test that an unauthenticated user is able to access the project list
f1a24fe
@DavisRayM
Check if request user is an anonymous user
37e0973 
Check if request user is an anonymous user and skip trying to get the
users project role
@DavisRayM DavisRayM merged commit ebe19e2 into master May 21, 2021
@DavisRayM DavisRayM deleted the 2082-exception-on-anonymous-user branch May 21, 2021 11:31
@DavisRayM DavisRayM mentioned this pull request May 31, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denniswambua denniswambua denniswambua approved these changes

@WinnyTroy WinnyTroy Awaiting requested review from WinnyTroy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception raised when retrieving projects list as an Anonymous user
2 participants
@DavisRayM @denniswambua