Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retrieve_org_or_project_list management command #2098

Merged
merged 3 commits into from
Jun 21, 2021

Conversation

DavisRayM
Copy link
Contributor

Changes / Features implemented

  • Add retrieve_org_or_project_list management command & tests

Steps taken to verify this change does what is intended

  • Added tests

Side effects of implementing this change

N/A

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #2051

@DavisRayM DavisRayM requested review from denniswambua, ukanga and WinnyTroy and removed request for ukanga and denniswambua June 2, 2021 13:27
@DavisRayM DavisRayM force-pushed the 2051-project-and-org-member-retrieval branch from d6fd47b to 28c767d Compare June 2, 2021 14:01
ret[perm.user.username]['permissions'].append(perm.permission.codename)

for user in ret.keys():
ret[user]['permissions'].sort()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason we are sorting this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really... I've changed this in the latest commit



def get_project_users(project):
ret = {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above two functions looks like good candidates to be in a util file and can be reused in other places

@DavisRayM DavisRayM force-pushed the 2051-project-and-org-member-retrieval branch 8 times, most recently from e6ca79a to cafbc05 Compare June 11, 2021 07:31
denniswambua
denniswambua previously approved these changes Jun 14, 2021
@DavisRayM DavisRayM merged commit 0445d40 into master Jun 21, 2021
@DavisRayM DavisRayM deleted the 2051-project-and-org-member-retrieval branch June 21, 2021 07:51
@DavisRayM DavisRayM mentioned this pull request Jul 27, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate retrieving list of collaborators for Orgs and Projects
2 participants