Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure content-disposition header is correctly encoded #2116

Merged
merged 2 commits into from
Jul 8, 2021

Conversation

DavisRayM
Copy link
Contributor

@DavisRayM DavisRayM commented Jul 6, 2021

Changes / Features implemented

  • Ensure content-disposition header is encoded correctly

Steps taken to verify this change does what is intended

  • Added tests

Side effects of implementing this change

  • N/A

Before submitting this PR for review, please make sure you have:

  • Included tests
    - [ ] Updated documentation

Closes #2106

@DavisRayM DavisRayM merged commit d3d728d into master Jul 8, 2021
@DavisRayM DavisRayM deleted the 2106-s3-storage-header-fix branch July 8, 2021 07:22
@DavisRayM DavisRayM mentioned this pull request Jul 27, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 redirect to error page for some file downloads
2 participants