Handle columns in groups and repeats in get_columns_by_type() #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniswambua
previously approved these changes
Jan 6, 2022
denniswambua
force-pushed
the
columns-by-type-update
branch
from
5a126c7
to
b356e77
Compare
denniswambua
force-pushed
the
columns-by-type-update
branch
from
b356e77
to
bad6acd
Compare
denniswambua
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Add support for handling CSV columns when the field is a group or a repeat. Ensure's the correct validation and field formatting especially for dates is applied to fields in during a CSV import of data.
Steps taken to verify this change does what is intended
Added a test.
Side effects of implementing this change
None
Before submitting this PR for review, please make sure you have:
Closes #