Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove namespace attribute from returned XML if present #2139

Merged
merged 2 commits into from
Aug 23, 2021

Conversation

DavisRayM
Copy link
Contributor

Changes / Features implemented

  • Add a trigger that can be used to disable the removal of the namespace
  • Remove namespace attribute from returned XML if present

Steps taken to verify this change does what is intended

  • Added tests

Side effects of implementing this change

The submission XML given to briefcase will now no longer include a namespace; Briefcase adds a namespace when pulling submissions from the server.

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #1790
Closes #1763

@DavisRayM DavisRayM merged commit 7be8919 into master Aug 23, 2021
@DavisRayM DavisRayM deleted the 1790-briefcase-export-fix branch August 23, 2021 12:22
@DavisRayM DavisRayM mentioned this pull request Aug 26, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug on ODK Briefcase ODK Briefcase v1.17+ Support
2 participants