Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore form permissions when an Export is from a public form #2164

Merged
merged 3 commits into from
Nov 4, 2021

Conversation

DavisRayM
Copy link
Contributor

@DavisRayM DavisRayM commented Oct 28, 2021

Changes / Features implemented

  • Return queryset containing all exports if XForm is public

Steps taken to verify this change does what is intended

  • Added tests

Side effects of implementing this change

Form permissions will be ignored when it comes to retrieving exports

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #2165

@DavisRayM DavisRayM force-pushed the public-form-editor-user-export branch 3 times, most recently from 99ecdff to 7e1f6f7 Compare October 28, 2021 13:34
@DavisRayM DavisRayM force-pushed the public-form-editor-user-export branch from 7e1f6f7 to 5684f47 Compare October 28, 2021 13:57
@DavisRayM DavisRayM force-pushed the public-form-editor-user-export branch from 5684f47 to 8539638 Compare October 29, 2021 07:19
@DavisRayM DavisRayM enabled auto-merge (squash) November 4, 2021 10:21
@DavisRayM DavisRayM merged commit 74ffb93 into master Nov 4, 2021
@DavisRayM DavisRayM deleted the public-form-editor-user-export branch November 4, 2021 13:04
@DavisRayM DavisRayM mentioned this pull request Nov 17, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authenticated User can't Download Export From a Public Form
2 participants